DEVPROD-14354 avoid a division-by-zero when processing empty suites #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikhailShchatko
approved these changes
Jan 22, 2025
smcclure15
approved these changes
Jan 22, 2025
src/task_types/resmoke_tasks.rs
Outdated
Comment on lines
517
to
519
| if n_suites == 0 { | ||
| return Ok(sub_suites); | ||
| } |
Collaborator
There was a problem hiding this comment.
nit: can this early-return occur before getting origin_suite? Always like to push the bailouts up as high as possible
Collaborator
Author
There was a problem hiding this comment.
Not quite before origin_suite, but I have now moved it up as far as it can be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests returned by resmoke's test discovery for a task may be empty. The codepath for splitting the task when stats from evergreen are successfully collected handles this, but the fallback method here naively did not. An empty list of sub-suites should be returned to match behavior.