TOOLS-4148 Replace waitgroup + tomb with an errgroup in ingestDocuments#985
Conversation
This was referenced Apr 3, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 3, 2026
autarch
force-pushed
the
04-03-tools-4148_replace_waitgroup_tomb_with_an_errgroup_in_ingestdocuments_
branch
from
4b83a4c to
4ba2210
Compare
autarch
force-pushed
the
04-03-tools-4148_replace_a_waitgroup_tomb_with_an_errgroup_in_streamdocuments_
branch
from
68f8a39 to
b121ef3
Compare
autarch
force-pushed
the
04-03-tools-4148_replace_waitgroup_tomb_with_an_errgroup_in_ingestdocuments_
branch
2 times, most recently
from
231ee85 to
d8b63da
Compare
autarch
force-pushed
the
04-03-tools-4148_replace_a_waitgroup_tomb_with_an_errgroup_in_streamdocuments_
branch
2 times, most recently
from
1305254 to
e6930e3
Compare
autarch
force-pushed
the
04-03-tools-4148_replace_waitgroup_tomb_with_an_errgroup_in_ingestdocuments_
branch
from
d8b63da to
20dae74
Compare
…nts` The embedded `tomb.Tomb` in MongoImport was replicating an errgroup. This removes it in favor passing a context into `ingestDocuments` and `runInsertionWorker`. We now check for `ctx.Done()` inside the loop where we read docs to be inserted.
autarch
force-pushed
the
04-03-tools-4148_replace_a_waitgroup_tomb_with_an_errgroup_in_streamdocuments_
branch
from
e6930e3 to
e01af14
Compare
autarch
force-pushed
the
04-03-tools-4148_replace_waitgroup_tomb_with_an_errgroup_in_ingestdocuments_
branch
from
20dae74 to
ea0773c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embedded
tomb.Tombin MongoImport was replicating an errgroup. This removes it in favor passing a context intoingestDocumentsandrunInsertionWorker. We now check forctx.Done()inside the loop where we read docs to be inserted.