Revert "SERVER-76796 Enable more lint warnings and fix them"

This reverts commit 7e0887b.

Author: auto-revert-processor

.pylintrc

@@ -13,12 +13,15 @@ variable-rgx=[a-z_][a-z0-9_]{1,50}$
 
 [MESSAGES CONTROL]
 # C0103 - invalid-name - Fix variable names to match convention
+# C0200 - consider-using-enumerate - Prefer enumerate() when you need index and value from an iterable
+# C0201 - consider-iterating-dictionary
 # C0206 - consider-using-dict-items - Need to explicitly specify .keys() or .items() in a dictionary iteration
 # C0207 - use-maxsplit-arg - Use maxsplit arg in split() calls
 # C0209 - consider-using-f-string - Need to convert most format strings (using both % and .format) to f""-style strings
 # C0301 - line-too-long - some of the type annotations are longer then 100 columns
 # C0325 - superfluous-parens - Superfluous parens, easy to fix
 # C0330 - bad-continuation - ignore conflicts produced by yapf formatting
+# C1803 - use-implicit-booleaness-not-comparison
 # C2801 - unnecessary-dunder-call - Prefer a builtin call instead of a dunder method
 # C3001 - unnecessary-lambda-assignment - Prefer def over lambda
 
@@ -33,10 +36,12 @@ variable-rgx=[a-z_][a-z0-9_]{1,50}$
 
 # R0204 - redefined-variable-type
 # R0205 - useless-object-inheritance - See PM-1380
+# R0402 - consider-using-from-import - Use better convention for module import
 # R0801 - duplicate-code - See PM-1380
 # R0903 - too-few-public-methods - pylint does not always know best
 # R1705 - no-else-return - sometimes an unnecessary else helps readability
 # R1710 - inconsistent-return-statements
+# R1714 - consider-using-in - Use 'x in [...]' instead
 # R1720 - no-else-raise - See PM-1380
 # R1728 - consider-using-generator - Use a generator instead of creating an in-memory list
 # R1730 - consider-using-min-builtin - Lots of situations where min() can be used to eliminate an if block
@@ -59,6 +64,7 @@ variable-rgx=[a-z_][a-z0-9_]{1,50}$
 # W0621 - redefined-outer-name - Overriding variable name
 # W0640 - cell-var-from-loop
 # W0719 - broad-exception-raised - Should use a more precise exception than `Exception`
+# W1406 - redundant-u-string-prefix
 # W1505 - deprecated-method - See PM-1380
 # W1514 - unspecified-encoding - Need to add 'encoding="utf-8"' to most open() operations
 # W3101 - missing-timeout - Add an explicit timeout to some sync functions
@@ -70,8 +76,12 @@ disable=
     broad-exception-raised,
     cell-var-from-loop,
     consider-using-dict-items,
+    consider-using-enumerate,
     consider-using-f-string,
+    consider-using-from-import,
     consider-using-generator,
+    consider-using-in,
+    consider-iterating-dictionary,
     consider-using-max-builtin,
     consider-using-min-builtin,
     consider-using-with,
@@ -103,6 +113,7 @@ disable=
     no-name-in-module,
     protected-access,
     raise-missing-from,
+    redundant-u-string-prefix,
     redefined-outer-name,
     subprocess-run-check,
     super-init-not-called,
@@ -129,8 +140,10 @@ disable=
     unused-argument,
     use-dict-literal,
     use-list-literal,
+    use-implicit-booleaness-not-comparison,
     used-before-assignment,
     useless-object-inheritance,
+    useless-suppression,
     wrong-import-order
 enable=useless-suppression
 

buildscripts/blackduck_hub.py

@@ -1184,7 +1184,7 @@ def run(self, logger: ReportLogger, report_file: Optional[str], vulnerabilties_o
         # We filter ourself our of the list of components.
         self.black_duck_components = [
             comp for comp in self.black_duck_components
-            if not (comp.name in ["MongoDB", "WiredTiger"])
+            if not (comp.name == "MongoDB" or comp.name == "WiredTiger")
         ]
 
         # Remove duplicate Black Duck components. We only care about the component with highest version number

buildscripts/ciconfig/evergreen.py

@@ -15,7 +15,7 @@
 
 import yaml
 
-from buildscripts.util import runcommand
+import buildscripts.util.runcommand as runcommand
 
 ENTERPRISE_MODULE_NAME = "enterprise"
 ASAN_SIGNATURE = "detect_leaks=1"

buildscripts/gdb/optimizer_printers.py

@@ -892,10 +892,10 @@ def get_dynamic_type(self):
         # from the _tag member variable.
         poly_type = self.val.type.template_argument(self.tag)
         dynamic_type = "mongo::optimizer::algebra::ControlBlockVTable<" + poly_type.name
-        for i, val in enumerate(self.type_set):
+        for i in range(len(self.type_set)):
             if i < len(self.type_set):
                 dynamic_type += ", "
-            dynamic_type += self.type_namespace + val
+            dynamic_type += self.type_namespace + self.type_set[i]
         dynamic_type += ">::ConcreteType"
         return dynamic_type
 

buildscripts/idl/gen_all_feature_flag_list.py

@@ -41,7 +41,7 @@
 sys.path.append(os.path.normpath(os.path.join(os.path.abspath(__file__), '../../..')))
 
 # pylint: disable=wrong-import-position
-from buildscripts.idl import lib
+import buildscripts.idl.lib as lib
 from buildscripts.idl.idl import parser
 
 

buildscripts/idl/idl/binder.py

@@ -925,7 +925,7 @@ def _bind_expression(expr, allow_literal_string=True):
     node.export = True
 
     # bool
-    if expr.literal in ["true", "false"]:
+    if (expr.literal == "true") or (expr.literal == "false"):
         node.expr = expr.literal
         return node
 

buildscripts/idl/idl/errors.py

@@ -358,7 +358,7 @@ def is_scalar_bool_node(self, node, node_name):
         if not self._is_node_type(node, node_name, "scalar"):
             return False
 
-        if not node.value in ["true", "false"]:
+        if not (node.value == "true" or node.value == "false"):
             self._add_node_error(
                 node, ERROR_ID_IS_NODE_VALID_BOOL,
                 "Illegal bool value for '%s', expected either 'true' or 'false'." % node_name)

buildscripts/libdeps/graph_visualizer_web_stack/flask/flask_backend.py

@@ -218,7 +218,7 @@ def add_link_to_graph_data(source, target, data):
                 if "transitive_edges" in req_body.keys() and req_body["transitive_edges"] is True:
                     for node in selected_nodes:
                         for libdep in dependency_graph[str(node)]:
-                            if str(libdep) in nodes:
+                            if str(libdep) in nodes.keys():
                                 add_link_to_graph_data(node, libdep,
                                                        dependents_graph[libdep][str(node)])
 

buildscripts/linter/mongolint.py

@@ -111,7 +111,9 @@ def _check_newlines(self):
     def _check_and_strip_comments(self):
         in_multi_line_comment = False
 
-        for linenum, clean_line in enumerate(self.raw_lines):
+        for linenum in range(len(self.raw_lines)):
+            clean_line = self.raw_lines[linenum]
+
             # Users can write NOLINT different ways
             # // NOLINT
             # // Some explanation NOLINT

buildscripts/powercycle_operations.py

@@ -9,6 +9,6 @@
     sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
 # pylint: disable=wrong-import-position
-from buildscripts.powercycle_setup import cli
+import buildscripts.powercycle_setup.cli as cli
 
 cli.main(sys.argv)