Skip to content

Conversation

@blva
Copy link
Collaborator

@blva blva commented May 20, 2022

Proposed changes

Part of the bug squash and design feedback

Removing the double statement Creating your cluster... [It's safe to 'Ctrl + C']

➜  mongocli git:(remove_extra_print) atlasdev setup
you are already authenticated with an account (bianca.vianadeaguiar+1234569@mongodb.com)

run "atlas auth setup --profile <profile_name>" to create a new Atlas account on a new Atlas CLI profile

[Default Settings]
Cluster Name:				Cluster53972
Cloud Provider and Region:		AWS - US_EAST_1
Database User Username:			Cluster53972
Allow connections from (IP Address):	37.228.237.17
? Do you want to set up your first free database in Atlas with default settings (it's free forever)? Yes
We are deploying Cluster53972...

Please store your database authentication access details in a secure location:
Database User Username: Cluster53972
Database User Password: Tk9EWFJvZ1NP

Creating your cluster... [It's safe to 'Ctrl + C']
Cluster created.
Loading sample data into your cluster... [It's safe to 'Ctrl + C']

[MongoDB Shell (mongosh) is an interactive command line interface to query, update and manage data in the MongoDB database.]
? Do you want to connect to Cluster53972 with MongoDB Shell? No

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva marked this pull request as ready for review May 20, 2022 11:46
@blva blva requested a review from a team May 20, 2022 11:46
@blva blva changed the title Remove extra print statement Address design feedback May 20, 2022
colm-quinn
colm-quinn previously approved these changes May 20, 2022
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: LGTM

@blva blva dismissed stale reviews from colm-quinn and ciprian-tibulca via e8f9cbe May 20, 2022 14:41
@blva blva merged commit a83ba08 into master May 20, 2022
@blva blva deleted the remove_extra_print branch May 20, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants