-
Notifications
You must be signed in to change notification settings - Fork 87
CLOUDP-123993: Remove unnecessary mentioning to profiles #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
internal/cli/default_setter_opts.go
Outdated
| Store ProjectOrgsLister | ||
| OutWriter io.Writer | ||
| AskedOrgsOrProjects bool | ||
| AskOrgsAndProjectsText string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[optional]
AskOrgsAndProjectsText to control the flow (not only as a label) which is a bit confusing.
What do you think about this alternative:
- instead of AskOrgsAndProjectsText have a field
OnMultipleOrgsOrProjects func () void - set this field in in login.go (instead of setting opts.AskOrgsAndProjectsText) with the content from displayInitialSelectText()
- in AskOrg / AskProject instead of calling opts.displayInitialSelectText(), call opts.OnMultipleOrgsOrProjects() (if it's not nil)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that seems like a better extensible approach! Thank you
Proposed changes
Jira ticket: CLOUDP-123993
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments