CLOUDP-120254: Address advocate experience feedback #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaangiolillo
approved these changes
Jun 1, 2022
melissamahoney-mongodb
requested changes
Jun 1, 2022
Contributor
melissamahoney-mongodb
left a comment
melissamahoney-mongodb
left a comment
There was a problem hiding this comment.
A few suggestions to make it a little shorter and cleaner. :)
internal/cli/auth/login.go
Outdated
| // Only make references to profile if user was asked about org or projects | ||
| if opts.AskedOrgsOrProjects && opts.ProjectID != "" && opts.OrgID != "" { | ||
| if !opts.ProjectExists(config.ProjectID()) { | ||
| return fmt.Errorf("you don't have access to the project id you provided or it does not exist") |
Contributor
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("you don't have access to the project id you provided or it does not exist") | |
| return fmt.Errorf("You don't have access to this project ID or it doesn't exist.") |
Collaborator
Author
There was a problem hiding this comment.
thanks, addressed most of them except the upper case and the period because for error messages we cannot add this (linter doesn't allow)
internal/cli/auth/login.go
Outdated
| } | ||
|
|
||
| if !opts.OrgExists(config.OrgID()) { | ||
| return fmt.Errorf("you don't have access to the organization id you provided or it does not exist") |
Contributor
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("you don't have access to the organization id you provided or it does not exist") | |
| return fmt.Errorf("You don't have access to this organization ID or it doesn't exist.") |
Collaborator
Author
There was a problem hiding this comment.
thanks, addressed most of them except the upper case and the period because for error messages we cannot add this (linter doesn't allow)
fmenezes
reviewed
Jun 1, 2022
fmenezes
requested changes
Jun 1, 2022
fmenezes
approved these changes
Jun 1, 2022
Collaborator
|
@blva thanks for the changes |
ciprian-tibulca
added a commit
that referenced
this pull request
Jun 10, 2022
* CLOUDP-120254: Address advocate experience feedback (#1281) * CLOUDP-124560: Add login to quickstart (#1284) * CLOUDP-118914: Clean up after tests that set config (#1285) * CLOUDP-118914: Save selected values and ask setup in a loop (#1297) * license header Co-authored-by: Bianca <40155621+blva@users.noreply.github.com> Co-authored-by: Bianca <bianca.vianadeaguiar@mongodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket:CLOUDP-120254
Improve the flow experience when user types invalid project id. Previously we were setting the profile and later failing with
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments