Skip to content

Conversation

@blva
Copy link
Collaborator

@blva blva commented Jun 3, 2022

Proposed changes

Jira ticket: CLOUDP-122445

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva changed the base branch from master to onboarding_improvements June 3, 2022 13:58
@blva blva force-pushed the CLOUDP-118914 branch 2 times, most recently from e967614 to 572433d Compare June 3, 2022 14:18
@blva blva force-pushed the CLOUDP-118914 branch from 572433d to 515f86b Compare June 3, 2022 14:19
@blva blva marked this pull request as ready for review June 3, 2022 14:27
@blva blva requested a review from a team June 3, 2022 14:27
@blva blva changed the title CLOUDP-118914: Clean up config after tests CLOUDP-122445: Clean up config after tests Jun 3, 2022
Copy link
Contributor

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva merged commit ced9316 into onboarding_improvements Jun 3, 2022
@blva blva deleted the CLOUDP-118914 branch June 3, 2022 16:19
ciprian-tibulca added a commit that referenced this pull request Jun 10, 2022
* CLOUDP-120254: Address advocate experience feedback (#1281)

* CLOUDP-124560: Add login to quickstart (#1284)

* CLOUDP-118914: Clean up after tests that set config (#1285)

* CLOUDP-118914: Save selected values and ask setup in a loop (#1297)

* license header

Co-authored-by: Bianca <40155621+blva@users.noreply.github.com>
Co-authored-by: Bianca <bianca.vianadeaguiar@mongodb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants