Skip to content

chore: Minor fix to update SDK #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2025
Merged

chore: Minor fix to update SDK #4340

merged 2 commits into from
Nov 26, 2025

Conversation

@cveticm
Copy link
Collaborator

@cveticm cveticm commented Nov 26, 2025 •
edited
Loading

Proposed changes

  • Issue 1:
    • If no SDK update, action always fails on task auto merge
      Solution:
      • Add caveat that auto-merge is only set if there is an sdk update
  • Issue 2:
    • If sdk update results in changes that cause build failures, task make gen-purls will fail, preventing the PR from being opened
      Solution:
      • Move this task to after PR is opened. This provides greater visual that an SDK update is available but has changes that cause failure.

@cveticm cveticm requested a review from a team as a code owner November 26, 2025 10:51
blva
blva approved these changes Nov 26, 2025
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@cveticm cveticm merged commit d2db242 into master Nov 26, 2025
25 checks passed
@cveticm cveticm deleted the chore-fix-update-sdk branch November 26, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blva blva blva approved these changes

Assignees

No one assigned

Labels

atlascli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cveticm @blva