Skip to content

Conversation

@gssbzn
Copy link
Contributor

@gssbzn gssbzn commented Jan 28, 2021

Proposed changes

Our tests are becoming slower as we add more so adding a couple of t.Parallel where we can.
I don't think this is helping much so far comparing with previous runs but hopefully we can keep this pattern around

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

@gssbzn gssbzn marked this pull request as ready for review February 3, 2021 10:33
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit 938eb71 into master Feb 3, 2021
@gssbzn gssbzn deleted the test-parallel branch February 3, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants