Skip to content

CLOUDP-106123: [mongocli ] Implement mongocli auth logout #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 2, 2022
Merged

CLOUDP-106123: [mongocli ] Implement mongocli auth logout #963

merged 4 commits into from
Feb 2, 2022

Conversation

@gssbzn
Copy link
Contributor

@gssbzn gssbzn commented Feb 2, 2022 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-106123

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

./bin/mongocli auth logout --profile test
? Are you sure you want to log out No

./bin/mongocli auth logout --profile test
? Are you sure you want to log out Yes
Successfully logged out

./bin/mongocli auth logout --profile test
Error: not logged in

gssbzn
gssbzn commented Feb 2, 2022
View reviewed changes
internal/cli/delete_opts.go

var err error
switch f := d.(type) {
case func() error:
Copy link
Contributor Author

@gssbzn gssbzn Feb 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding support for a no "entry" case

@gssbzn gssbzn marked this pull request as ready for review February 2, 2022 17:32
@gssbzn gssbzn requested review from a team and colm-quinn and removed request for a team February 2, 2022 17:32
blva
blva reviewed Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@gssbzn gssbzn requested a review from blva February 2, 2022 18:09
@gssbzn gssbzn merged commit 9a2ec62 into master Feb 2, 2022
@gssbzn gssbzn deleted the CLOUDP-106123 branch February 2, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blva blva blva approved these changes

@colm-quinn colm-quinn Awaiting requested review from colm-quinn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gssbzn @blva