Skip to content

Fix gorelease task on evergreen #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 3, 2022
Merged

Fix gorelease task on evergreen #964

merged 4 commits into from
Feb 3, 2022

Conversation

@andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Feb 3, 2022 •
edited
Loading

Proposed changes

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

Description:
Mongocli release is currently blocked because Release (goreleaser)](https://evergreen.mongodb.com/task/mongocli_master_release_github_release__v1.22.0_22_02_03_11_11_38) is failing with the error

 [2022/02/03 12:07:36.054]    • getting and validating git state
 [2022/02/03 12:07:36.121]       • building...               commit=d77aa48c9751122868b2dfb01a3ad4bef960d166 latest tag=v1.22.0
 [2022/02/03 12:07:36.146]    ⨯ release failed after 0.09s error=git is currently in a dirty state, please check in your pipeline what can be changing the following files:
 [2022/02/03 12:07:36.146] ?? darwin_amd64/
 [2022/02/03 12:07:36.146] ?? macos-notary.zip
 [2022/02/03 12:07:36.148] Command failed: command encountered problem: error waiting on process '9fa609d0-83f6-4909-8358-842b3e1a66fa': exit status 1
 [2022/02/03 12:07:36.148] Task completed - FAILURE.

Fix:
This PR adds the mac notazation binary to the .gitignore

@andreaangiolillo andreaangiolillo requested review from a team and colm-quinn and removed request for a team and colm-quinn February 3, 2022 12:35
@andreaangiolillo andreaangiolillo changed the title Fix release Fix gorelease task on evergreen Feb 3, 2022
gssbzn
gssbzn reviewed Feb 3, 2022
View reviewed changes
build/ci/evergreen.yml
- command: shell.exec
type: setup
params:
working_dir: src/github.com/mongodb/mongocli
Copy link
Contributor

@gssbzn gssbzn Feb 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding macos-notary.zip to the gitignore is probably better fix

Copy link
Collaborator Author

@andreaangiolillo andreaangiolillo Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack. I will do it

gssbzn
gssbzn approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 4502476 into master Feb 3, 2022
@andreaangiolillo andreaangiolillo deleted the fix_release branch February 3, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gssbzn gssbzn gssbzn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreaangiolillo @gssbzn