CLOUDP-175080: Deletion protection for project resources (final)

[helderjs]

All Submissions:

• Have you signed our CLA?
• Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
• Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

[github-actions]

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/e82713d40e23cb9005f6aca6a8fa3da03c801c40

[igor-karpukhin]

Massive work here! Good job! 👍

[josvazg]

Why not this instead?

Suggested change

	if akoMWindow.DayOfWeek != atlasMWindow.DayOfWeek {
	return false
	}
	if akoMWindow.HourOfDay != *atlasMWindow.HourOfDay {
	return false
	}
	if akoMWindow.StartASAP != *atlasMWindow.StartASAP {
	return false
	}
	if akoMWindow.AutoDefer != *atlasMWindow.AutoDeferOnceEnabled {
	return false
	}
	return true
	return akoMWindow.DayOfWeek == atlasMWindow.DayOfWeek &&
	akoMWindow.HourOfDay == *atlasMWindow.HourOfDay &&
	akoMWindow.StartASAP == *atlasMWindow.StartASAP &&
	akoMWindow.AutoDefer == *atlasMWindow.AutoDeferOnceEnabled

For me it is easier to read as it separates the pointer value fixes above from the actual equals check.

[josvazg]

nitpick
This seems to be a format conversion. Moving to its own function could made this more readable.

Suggested change

	atlasAssignedTeamsInfo := make([]assignedTeamInfo, 0, atlasAssignedTeams.TotalCount)
	for _, atlasAssignedTeam := range atlasAssignedTeams.Results {
	if atlasAssignedTeam != nil {
	atlasAssignedTeamsInfo = append(
	atlasAssignedTeamsInfo,
	assignedTeamInfo{
	ID: atlasAssignedTeam.TeamID,
	Roles: atlasAssignedTeam.RoleNames,
	},
	)
	}
	}
	atlasAssignedTeamsInfo := atlasAssignedTeamsToInfos(atlasAssignedTeams.Results)

[josvazg]

LGTM

All my comments are non blocking nitpicks