CLOUDP-201083: Improve validation and handling of advanced deployments #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
reviewed
Sep 27, 2023
josvazg
reviewed
Sep 27, 2023
| var err error | ||
| for _, replicationSpec := range replicationSpecs { | ||
| for _, regionSpec := range replicationSpec.RegionConfigs { | ||
| if regionSpec.AutoScaling == nil || regionSpec.AutoScaling.Compute == nil || regionSpec.AutoScaling.Compute.Enabled == nil || !*regionSpec.AutoScaling.Compute.Enabled { |
Collaborator
There was a problem hiding this comment.
nitpick, for this complex logic statement it helps readability to create a function with a descriptive name that summarizes the semantics of the change.
Suggested change
| if regionSpec.AutoScaling == nil || regionSpec.AutoScaling.Compute == nil || regionSpec.AutoScaling.Compute.Enabled == nil || !*regionSpec.AutoScaling.Compute.Enabled { | |
| if autoscalingComputeDisabled(regionSpec.AutoScaling) { |
josvazg
approved these changes
Sep 27, 2023
Collaborator
josvazg
left a comment
josvazg
left a comment
There was a problem hiding this comment.
LGTM
Great job and extra points for not needing adding code to e2e or integration tests!
helderjs
force-pushed
the
CLOUDP-201083-fix-autoscaling-config
branch
2 times, most recently
from
a334b3a to
862ced4
Compare
helderjs
force-pushed
the
CLOUDP-201083-fix-autoscaling-config
branch
from
862ced4 to
735fda0
Compare
josvazg
reviewed
Oct 4, 2023
Collaborator
|
Still LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).