Skip to content

Conversation

@josvazg
Copy link
Collaborator

@josvazg josvazg commented Oct 24, 2023

All Submissions:

  • Have you signed our CLA?

@josvazg josvazg force-pushed the fix-all-in-one-clusterrole branch 2 times, most recently from 21381a3 to 10ac926 Compare October 24, 2023 14:43
Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>
@josvazg josvazg force-pushed the fix-all-in-one-clusterrole branch from 10ac926 to 894f178 Compare October 24, 2023 14:46
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestions

Co-authored-by: Igor Karpukhin <karpukhinigor@gmail.com>
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@josvazg josvazg merged commit 4594b3b into main Oct 25, 2023
@josvazg josvazg deleted the fix-all-in-one-clusterrole branch October 25, 2023 07:22
josvazg added a commit that referenced this pull request Oct 25, 2023
* Fix all-in-one.yaml ClusterRole

Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>

* Apply suggestions from code review

Co-authored-by: Igor Karpukhin <karpukhinigor@gmail.com>

---------

Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>
Co-authored-by: Igor Karpukhin <karpukhinigor@gmail.com>
josvazg added a commit that referenced this pull request Oct 25, 2023
* Fix all-in-one.yaml ClusterRole



* Apply suggestions from code review



---------

Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>
Co-authored-by: Igor Karpukhin <karpukhinigor@gmail.com>
josvazg added a commit that referenced this pull request Oct 25, 2023
* Fix all-in-one.yaml ClusterRole (#1196) (#1198)

* Fix all-in-one.yaml ClusterRole



* Apply suggestions from code review



---------

Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>
Co-authored-by: Igor Karpukhin <karpukhinigor@gmail.com>

* Release 1.9.1

---------

Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>
Co-authored-by: josvaz <jose.vazquez@mongodb.com>
Co-authored-by: Igor Karpukhin <karpukhinigor@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants