-
Notifications
You must be signed in to change notification settings - Fork 107
Fix all-in-one.yaml ClusterRole #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21381a3 to
10ac926
Compare
Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>
10ac926 to
894f178
Compare
igor-karpukhin
requested changes
Oct 24, 2023
Collaborator
igor-karpukhin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggestions
Co-authored-by: Igor Karpukhin <karpukhinigor@gmail.com>
igor-karpukhin
approved these changes
Oct 24, 2023
Collaborator
igor-karpukhin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
josvazg
added a commit
that referenced
this pull request
Oct 25, 2023
* Fix all-in-one.yaml ClusterRole Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com> * Apply suggestions from code review Co-authored-by: Igor Karpukhin <karpukhinigor@gmail.com> --------- Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com> Co-authored-by: Igor Karpukhin <karpukhinigor@gmail.com>
josvazg
added a commit
that referenced
this pull request
Oct 25, 2023
josvazg
added a commit
that referenced
this pull request
Oct 25, 2023
* Fix all-in-one.yaml ClusterRole (#1196) (#1198) * Fix all-in-one.yaml ClusterRole * Apply suggestions from code review --------- Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com> Co-authored-by: Igor Karpukhin <karpukhinigor@gmail.com> * Release 1.9.1 --------- Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com> Co-authored-by: josvaz <jose.vazquez@mongodb.com> Co-authored-by: Igor Karpukhin <karpukhinigor@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions: