CLOUDP-194457: Cover new DATADOG supported regions and add PagerDuty test #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helderjs
requested review from
igor-karpukhin,
josvazg,
roothorp and
s-urbaniak
s-urbaniak
reviewed
Nov 23, 2023
s-urbaniak
reviewed
Nov 23, 2023
|
|
||
| Expect(err).ShouldNot(HaveOccurred()) | ||
| By("Integration is ready", func() { | ||
| actions.WaitForConditionsToBecomeTrue(data, status.IntegrationReadyType, status.ReadyType) |
Collaborator
There was a problem hiding this comment.
clarification question: this waits for the Update which happened in line 142 to be reflected in the conditions, right?
Collaborator
Author
There was a problem hiding this comment.
Yes, we wait the operator do his job and see the condition IntegrationReadyType become ready
josvazg
approved these changes
Nov 24, 2023
Collaborator
|
lGTM when it passes CI |
helderjs
force-pushed
the
CLOUDP-194457-project-integration-test
branch
from
fd8151e to
42594e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).