CLOUDP-212277: Disable deletion protection for Backups #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-karpukhin
changed the title
igor-karpukhin
added
the
cloud-tests
josvazg
approved these changes
Nov 28, 2023
Collaborator
josvazg
left a comment
josvazg
left a comment
There was a problem hiding this comment.
LGTM if it passed the CI as well
helderjs
approved these changes
Nov 28, 2023
s-urbaniak
approved these changes
Nov 28, 2023
Collaborator
s-urbaniak
left a comment
s-urbaniak
left a comment
There was a problem hiding this comment.
lgtm, however, why don't we also remove all the logic that asserts default backup schedules as well? @igor-karpukhin
Collaborator
Author
|
@s-urbaniak there were no logic to compare a backup schedule to the default one. It was added in the PR that I closed recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Disable deletion protection from Backups as the operator can not detect if values for backups are default ones or changed by customers.
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).