CLOUDP-212108: Fix net peering cleanups #1265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
commented
Nov 29, 2023
Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>
josvazg
force-pushed
the
CLOUDP-212108/fix-np-cleanups
branch
from
90405ba to
ad0d922
Compare
s-urbaniak
approved these changes
Nov 29, 2023
helderjs
requested changes
Nov 29, 2023
| if err != nil { | ||
| fmt.Println(text.FgRed.Sprintf("\tFailed to list networking peering for project %s: %s", projectID, err)) | ||
| var ( | ||
| SupportedProviders = []string{"AWS", "AZURE", "GCP"} |
Collaborator
There was a problem hiding this comment.
In atlas.go there are already constants with the supported cloud providers, please reuse them
| SupportedProviders = []string{"AWS", "AZURE", "GCP"} | ||
| ) | ||
|
|
||
| func (c *Cleaner) listNetworkPeering(ctx context.Context, projectID string) []admin.BaseNetworkPeeringConnectionSettings { |
Collaborator
There was a problem hiding this comment.
See GetProjectDependencies() in projects.go and consider move the provider logic to there.
Reason is that Gov only support AWS and make a request for other provider results in an error
| } | ||
|
|
||
| func (gcp *GCP) DeleteVpc(ctx context.Context, vpcName string) error { | ||
| vpcGetRequest := &computepb.GetNetworkRequest{ |
Collaborator
There was a problem hiding this comment.
Does GCP require subnets to be remove VPCs with subnets? seems strange
Collaborator
Author
There was a problem hiding this comment.
yes, it failed on my test until I added this code.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that
ListPeeringConnectionswould render only AWS related peering by default.Apart from that, GCP VPC removals could not be done before removing their subnets.
Fixing both here should probably fix the issues for GCP. For Azure we have not detected stuck entries so far.
All Submissions: