CLOUDP-82591: support removing the database users #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonlisovenko
commented
Mar 8, 2021
| - type | ||
| type: object | ||
| type: array | ||
| connectionSecrets: |
Contributor
Author
There was a problem hiding this comment.
forgot to run make manifests in the previous PR
added 2 commits
March 8, 2021 12:36
leo-ri
approved these changes
Mar 9, 2021
vasilevp
approved these changes
Mar 10, 2021
|
|
||
| for _, secret := range secrets { | ||
| // Solves the "Implicit memory aliasing in for loop" linter error | ||
| s := secret.DeepCopy() |
Contributor
There was a problem hiding this comment.
Alternatively, we could use secrets[i]
Contributor
Author
There was a problem hiding this comment.
good idea, will use in the future!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for database user removal. Ensures connection secrets are removed as well.
In addition checks for the database user statuses to contain connection secrets information - this was missed in the previous PR