CLOUDP-221979: Fix: Remove all search index status entries where ID is empty #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
approved these changes
May 8, 2024
Collaborator
josvazg
left a comment
josvazg
left a comment
There was a problem hiding this comment.
LGTM, while this does not hurt I believe the proper fix would be to actually handle errors within the state machine. But again, this is fine for now.
s-urbaniak
approved these changes
May 8, 2024
Collaborator
|
nit: please follow-up with a unit test |
igor-karpukhin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Fix: Remove all search index status entries where ID is empty
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).