Ensure secrets on cluster update #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonlisovenko
suggested changes
Mar 16, 2021
Contributor
antonlisovenko
left a comment
antonlisovenko
left a comment
There was a problem hiding this comment.
My hypothesis that querying the Atlas DB users won't work because the password won't be returned.
This can be proved/disproved by int tests I believe.
| DBUserName: dbUser.Username, | ||
| ConnURL: cluster.ConnectionStrings.Standard, | ||
| SrvConnURL: cluster.ConnectionStrings.StandardSrv, | ||
| Password: dbUser.Password, |
Contributor
There was a problem hiding this comment.
I'm not sure this will work - the password will be empty on GET requests
| } | ||
|
|
||
| func ensureConnectionSecrets(ctx context.Context, wctx *workflow.Context, k8sClient client.Client, project *mdbv1.AtlasProject, cluster *mongodbatlas.Cluster) workflow.Result { | ||
| dbUsers, _, err := wctx.Client.DatabaseUsers.List(ctx, project.ID(), &mongodbatlas.ListOptions{}) |
Contributor
There was a problem hiding this comment.
we need to query K8s database users as we know the passwords for them only - not for Atlas db users
Contributor
Author
There was a problem hiding this comment.
Ah, that makes sense... Guess this is going to be a bit more complicated then 🙂
antonlisovenko
suggested changes
Mar 30, 2021
antonlisovenko
approved these changes
Mar 31, 2021
Contributor
antonlisovenko
left a comment
antonlisovenko
left a comment
There was a problem hiding this comment.
👍 as soon as the tests are green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.