CLOUDP-84905: support user expiration #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonlisovenko
commented
Mar 22, 2021
| log.Infof("Removed %d connection secrets", len(secrets)) | ||
| } | ||
| // We ignore the error as it will be printed by the function | ||
| _ = removeStaleSecretsByUserName(r.Client, project.ID(), userName, *dbUser, log) |
Contributor
Author
There was a problem hiding this comment.
moved to a single function as this code is reused by different places
antonlisovenko
commented
Mar 22, 2021
| return false, err | ||
| } | ||
|
|
||
| // performing some normalization of dates |
Contributor
Author
There was a problem hiding this comment.
this is necessary to correctly compare strings as the date returned by Atlas may be different than the one submitted by the Atlas Operator
…to CLOUDP-84905_mark-user-expired
…to CLOUDP-84905_mark-user-expired
…into CLOUDP-84905_mark-user-expired
vasilevp
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for database user expiration. If the
spec.DeleteAfterDateis less than the current date - no API requests are sent to Atlas, the resource is marked asready: falseandDatabaseUserReadyType: falseand connection secrets are removed. Note, that the retry of the reconciliation doesn't happen in this case as it's the user that needs to update the spec to fix this