-
Notifications
You must be signed in to change notification settings - Fork 107
CLOUDP-277319: Added helm automation job #2 #1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # - use the VERSION as arg of the bundle target (e.g make bundle VERSION=0.0.2) | ||
| # - use environment variables to overwrite this value (e.g export VERSION=0.0.2) | ||
| VERSION ?= $(shell git describe --tags --dirty --broken | cut -c 2-) | ||
| VERSION ?= $(shell git describe --always --tags --dirty --broken | cut -c 2-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does --always change in terms of VERSION generation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sure that git always returns exit code 0. Without it, if will fail with "Nothing to describe" if there are no tags
josvazg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this finally work? I can't see a working run here:
https://github.com/mongodb/mongodb-atlas-kubernetes/actions/workflows/update-helm.yaml
|
FYI, I created CLOUDP-278910 CI GH App token action consistent for a discussion |
|
@josvazg unfortunately it doesn't. But as you can see, I found a way to generate token inside the Github Action, instead of encoding the key with base64 and then calling a makefile |
|
Reopened as the workflow has been proved to be correct. The issue is with the credentials |
33d2f14 to
b336d99
Compare
|
Does this actually work? I fear there is no special permission to allow for a workflow in one repo to actually make a commit or PR on another repo. Instead, we will need to do this in 2 pieces:
If cross referencing repos has not been proved to work using a test Github App, I would assume it does not work. Using user level credentials might allow cross repo changes, but GitHub Apps might not get the same privileges, specially on org owned accounts. |
I can show you that it works in my two private repos |
With a Github App key? what permissions did you add exactly to get that working? |
Yes, with the Github App key. The app is installed in both repos and has permissions to create PRs in another repo. The workflow is the same. And it works. See the generated PR: igor-karpukhin/dotfiles#1 from the github actions job: https://github.com/igor-karpukhin/actions-test/blob/main/.github/workflows/createPR.yaml |
Cannot access your repo. Can you share the Github App credential permissions set? I think we will need to show those particular details to the team provisioning our GitHub org permissions. |
|
✅ Test helm update |
✅ Test helm update
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).