Skip to content

CLOUDP-20220: GCP test #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 31, 2022
Merged

CLOUDP-20220: GCP test #538

merged 11 commits into from
May 31, 2022

Conversation

@leo-ri
Copy link
Contributor

@leo-ri leo-ri commented May 25, 2022 •
edited
Loading

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@leo-ri leo-ri force-pushed the CLOUDP-120220-gcp-test branch 2 times, most recently from 73dc66e to 7cba8e7 Compare May 27, 2022 16:33
@leo-ri leo-ri force-pushed the CLOUDP-120220-gcp-test branch from e2f0e34 to 9d3287e Compare May 27, 2022 17:37
@leo-ri leo-ri marked this pull request as ready for review May 30, 2022 10:14
@leo-ri leo-ri changed the title Cloudp 120220 test Cloudp 120220 GCP test May 30, 2022
fabritsius
fabritsius approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@fabritsius fabritsius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great 👍

@leo-ri leo-ri changed the title Cloudp 120220 GCP test CLOUDP-20220: GCP test May 30, 2022
@leo-ri leo-ri requested a review from igor-karpukhin May 30, 2022 11:02
igor-karpukhin
igor-karpukhin approved these changes May 30, 2022
View reviewed changes
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@leo-ri leo-ri merged commit dfa0c2a into main May 31, 2022
@leo-ri leo-ri deleted the CLOUDP-120220-gcp-test branch May 31, 2022 09:11
fabritsius pushed a commit that referenced this pull request Jun 1, 2022
@leo-ri @fabritsius
CLOUDP-20220: GCP test (#538)
ab0899c
fabritsius pushed a commit that referenced this pull request Jun 1, 2022
@leo-ri @fabritsius
CLOUDP-20220: GCP test (#538)
65e9f9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

+1 more reviewer

@fabritsius fabritsius fabritsius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leo-ri @igor-karpukhin @fabritsius