CLOUDP-153400: Remove kubectl #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sugar-pack
force-pushed
the
remove-kubectl
branch
4 times, most recently
from
1eb5374 to
c41d86e
Compare
Sugar-pack
force-pushed
the
remove-kubectl
branch
from
c41d86e to
5640f1a
Compare
Sugar-pack
force-pushed
the
remove-kubectl
branch
2 times, most recently
from
a016678 to
a076e2a
Compare
Sugar-pack
force-pushed
the
remove-kubectl
branch
2 times, most recently
from
d388d5c to
2cc8260
Compare
Sugar-pack
force-pushed
the
remove-kubectl
branch
from
2cc8260 to
3c1542a
Compare
Sugar-pack
force-pushed
the
remove-kubectl
branch
from
3c1542a to
dd231b7
Compare
Sugar-pack
requested review from
fabritsius,
helderjs and
igor-karpukhin
and removed request for
fabritsius and
helderjs
fabritsius
reviewed
Jan 20, 2023
| var testData *model.TestDataProvider | ||
|
|
||
| _ = BeforeEach(func() { | ||
| Eventually(kubecli.GetVersionOutput()).Should(Say(K8sVersion)) |
Contributor
There was a problem hiding this comment.
I'm surprised that removing this doesn't cause any problems :)
I thought this is like "tell when you're ready flag".
Great if we don't need it at all 👌
Contributor
Author
There was a problem hiding this comment.
It's just a comparison between the existing and expected versions of kubectl
fabritsius
approved these changes
Jan 20, 2023
Contributor
fabritsius
left a comment
fabritsius
left a comment
There was a problem hiding this comment.
Looks great 👍
Just have one little question :)
helderjs
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).