CLOUDP-80774: support enums in the spec #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 25, 2021 17:33
…to main � Conflicts: � README.md
added 2 commits
February 10, 2021 18:35
vasilevp
approved these changes
Feb 10, 2021
Contributor
vasilevp
left a comment
vasilevp
left a comment
There was a problem hiding this comment.
LGTM, just a small style suggestion
| ProviderAzure ProviderName = "AZURE" | ||
| ProviderTenant ProviderName = "TENANT" | ||
|
|
||
| TypeReplicaSet ClusterType = "REPLICASET" |
Contributor
There was a problem hiding this comment.
[nit] It's good practice to separate different types into different const blocks. This also allows the Go documentation generator to parse comments for such blocks as relevant documentation.
Unofficial example: https://pkg.go.dev/github.com/fluhus/godoc-tricks#Mock_enums
leo-ri
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR transforms some of the fields to Enums. Unit tests are added to ensure behavior is not broken.
Note, that only two fields are added:
ProviderNameandClusterType. The suggestion is to do this gradually and also for those enums that are quite stable and "protected" by CRD enum validation.