CLOUDP-81143: Add failure scenarios to Cluster int tests #98
Conversation
vasilevp
changed the title
antonlisovenko
left a comment
antonlisovenko
left a comment
There was a problem hiding this comment.
just one question
| items: | ||
| description: TODO solve circular dependency (move ProjectIPAccessList | ||
| to subpackage?) Copy of mdbv1.ProjectIPAccessList | ||
| description: ProjectIPAccessList is a copy of mdbv1.ProjectIPAccessList |
test/int/cluster_test.go
Outdated
| createdCluster, | ||
| status. | ||
| FalseCondition(status.ClusterReadyType). | ||
| WithReason(string(workflow.Internal)). |
There was a problem hiding this comment.
[q] I would expect this to be ClusterNotCreatedInAtlas instead of Internal or am I missing something?
There was a problem hiding this comment.
Ok, I know the answer. It's not the create request that fails, but the client.Clusters.Get(ctx, project.Status.ID, cluster.Spec.Name) and this results in the internal error.
Can we please add the comment here to explain this as logically it seems that the creation should fail, not get
antonlisovenko
left a comment
antonlisovenko
left a comment
There was a problem hiding this comment.
Nice! 🥳
would be great to add the comment in the test about why it's 'internal'
test/int/cluster_test.go
Outdated
| createdCluster, | ||
| status. | ||
| FalseCondition(status.ClusterReadyType). | ||
| WithReason(string(workflow.Internal)). |
There was a problem hiding this comment.
Ok, I know the answer. It's not the create request that fails, but the client.Clusters.Get(ctx, project.Status.ID, cluster.Spec.Name) and this results in the internal error.
Can we please add the comment here to explain this as logically it seems that the creation should fail, not get
No description provided.