Skip to content
This repository was archived by the owner on Dec 12, 2025. It is now read-only.

Conversation

@corryroot
Copy link
Contributor

@corryroot corryroot commented Aug 30, 2022

Hi @jwilliams-mongo, @mircea-cosbuc, and @irajdeep, I added a note about the optional connectionStringSecretName field.

JIRA

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).


Update the variables in the following command, then run it to retrieve a user's connection strings to the replica set from the secret:

**NOTE**: The following command requires [jq](https://stedolan.github.io/jq/) version 1.6 or higher.</br></br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the example on line 51, consider replacing the specific secret variables with a catch-all variable that also covers the note you added

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my comment from the enterprise PR might also apply here

Copy link
Contributor

@jwilliams-mongo jwilliams-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corryroot LGTM with one suggestion

Copy link
Member

@mircea-cosbuc mircea-cosbuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@irajdeep irajdeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corryroot corryroot merged commit 6e2270c into mongodb:master Aug 31, 2022
@corryroot corryroot deleted the DOCSP-21766 branch August 31, 2022 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants