This repository was archived by the owner on Dec 12, 2025. It is now read-only.
fix confusing error message #1479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nammn
requested review from
Julien-Ben,
irajdeep,
lsierant,
mircea-cosbuc and
slaskawi
as code owners
nammn
commented
Jan 26, 2024
| automationAgentLogOptions = " -logFile ${AGENT_LOG_FILE} -maxLogFileDurationHrs ${AGENT_MAX_LOG_FILE_DURATION_HOURS} -logLevel ${AGENT_LOG_LEVEL}" | ||
|
|
||
| MongodbUserCommand = `current_uid=$(id -u) | ||
| declare -r current_uid |
Collaborator
Author
There was a problem hiding this comment.
We could merge with below var, but this seems easy enough once we need to do one change in the future
nammn
commented
Jan 26, 2024
| func AutomationAgentCommand() []string { | ||
| // AutomationAgentCommand withAgentAPIKeyExport detects whether we want to deploy this agent with the agent api key exported | ||
| // it can be used to register the agent with OM. | ||
| func AutomationAgentCommand(withAgentAPIKeyExport bool) []string { |
Collaborator
Author
There was a problem hiding this comment.
this method is used in meko as a base to create the agent command
Collaborator
Author
There was a problem hiding this comment.
lsierant
approved these changes
Jan 31, 2024
Collaborator
lsierant
left a comment
lsierant
left a comment
There was a problem hiding this comment.
One comment to consider, but in any way LGTM
| ` | ||
| MongodbUserCommandWithAPIKeyExport = `current_uid=$(id -u) | ||
| AGENT_API_KEY="$(cat /mongodb-automation/agent-api-key/agentApiKey)" |
Collaborator
There was a problem hiding this comment.
we might do this also by swallowing stderr to /dev/null.
Collaborator
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).removing error message in case that file does not exist. We do want to use it in case it exist, with this we have the opportunity to connect to OM via monitoring.