add WithAgentFlags function #148
Conversation
pkg/kube/container/containers.go
Outdated
| func WithAgentFlags(envs ...corev1.EnvVar) Modification { | ||
| return func(container *corev1.Container) { | ||
| agentParams := "" | ||
| for _, variable := range envs { | ||
| agentParams += " -" + variable.Name + " " + variable.Value | ||
| } | ||
| container.Env = envvar.MergeWithOverride(container.Env, []corev1.EnvVar{{Name: "AGENT_FLAGS", Value: agentParams}}) | ||
| } | ||
| } |
There was a problem hiding this comment.
nice implementation! I think however the containers package is not the correct place for this functionality. This specific function is now only exists for use with the agent (especially with the hard coded AGENT_FLAGS env var name)
To me this is something that we could leverage both in the community and enterprise operator, but I think it belongs in an agents or agent package, rather than container.
To me it makes more sense to have the following structure
[]customType -> []corev1.EnvVar -> container.WithEnvs(agentEnvs)
rather than including this logic in this package.
What do you think?
chatton
left a comment
chatton
left a comment
There was a problem hiding this comment.
Nice it looks great!
I think maybe we should add at least one or 2 basic unit tests to ensure we're getting the expected format, but after that I think we're good to merge!
This PR adds a
WithAgentFlagsfunction that sets up theAGENT_FLAGSenvironment variable from a slice of env var representing single agent startup flags.All Submissions: