This repository was archived by the owner on Dec 12, 2025. It is now read-only.
Extend dev image expiration #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
commented
Sep 9, 2020
scripts/git-hooks/pre-commit
Outdated
Comment on lines
50
to
51
| if ! [ -z $file ]; then | ||
| if ! golangci-lint run "${file}"; then |
Contributor
Author
There was a problem hiding this comment.
this pre-commit hook was failing when there were no go files being changed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Extending dev image expiration, 10 hours meant the images would be gone the following day, 48 hours gives us time to re-run tests that ran the previous day.