Headless mode readiness probe #192
Conversation
| .github | ||
| .idea | ||
| agent | ||
| build/_output |
There was a problem hiding this comment.
allows us to use operator-sdk build for faster local development
| See [here](deploy/crds/mongodb.com_v1_mongodb_openshift_cr.yaml) for an example of how to provide the required configuration for a MongoDB ReplicaSet. | ||
| See [here](deploy/operator_openshift.yaml) for an example of how to configure the Operator deployment. | ||
| See [here](deploy/openshift/operator_openshift.yaml) for an example of how to configure the Operator deployment. |
There was a problem hiding this comment.
moved the openshift example into another directory so it is still possible to do. kubectl apply -f deploy/ without deploying the operator twice
| RUN apt-get update && \ | ||
| apt-get install -y curl | ||
|
|
||
| ENV manifest_version=4.4 | ||
| RUN mkdir -p /content/ \ | ||
| && chmod -R +r /content/ \ | ||
| && curl --fail --retry 3 -o /usr/local/version_manifest.json "https://opsmanager.mongodb.com/static/version_manifest/${manifest_version}.json" |
There was a problem hiding this comment.
small update to add the version manifest to the "faster" local dev build using operator-sdk build
| ), | ||
| container.WithEnvs( | ||
| corev1.EnvVar{ | ||
| Name: headlessAgentEnv, |
There was a problem hiding this comment.
flag the readiness probe to go down the headless agent route
| }, | ||
| corev1.EnvVar{ | ||
| Name: podNamespaceEnv, | ||
| ValueFrom: &corev1.EnvVarSource{ | ||
| FieldRef: &corev1.ObjectFieldSelector{ | ||
| APIVersion: "v1", | ||
| FieldPath: "metadata.namespace", | ||
| }, | ||
| }, | ||
| }, | ||
| corev1.EnvVar{ | ||
| Name: automationConfigEnv, | ||
| Value: automationConfigSecretName, | ||
| }, |
There was a problem hiding this comment.
provide the readiness probe information about which secret to read from
rodrigovalin
left a comment
rodrigovalin
left a comment
There was a problem hiding this comment.
LGTM
what do you think about renaming status.members to status.currentMembers or something similar that indicates that it is a transient value that moves towards spec.members... ? Like the readyReplicas from STS? (no need for this PR)
|
@rodrigovalin I like your suggestion about the renaming! I think we can do this separately like you said 👍 |
All Submissions:
This PR updates the operator to configure the readiness probe in headless mode, instead of using just the health file as it was doing.