Change default permissions for volumes created from secret #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
reviewed
Sep 18, 2020
Contributor
chatton
left a comment
chatton
left a comment
There was a problem hiding this comment.
Looks good to me, as discussed in person we should add some unit tests to check the merging logic around this field.
added 2 commits
September 18, 2020 09:43
Contributor
Author
|
@chatton as discussed in person, putting a simple unit test for now and then I'll add a more proper tests around merging when fixing it. Ready for another review when you have time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default permissions on volumes created from a secret. This is needed for another work in the enterprise operator. It will still be possible to specify different modes through the yaml file (when the merging bug is fixed)
All Submissions: