Removed dependency on version manifest #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
commented
Feb 17, 2021
| BUNDLE_IMG ?= controller-bundle:$(VERSION) | ||
|
|
||
| # Image URL to use all building/pushing image targets | ||
| IMG ?= quay.io/mongodb/mongodb-kubernetes-operator:0.5.0 # replace with localhost:5000/mongodb-kubernetes-operator locally |
Contributor
Author
There was a problem hiding this comment.
removing the official registry as default to prevent any accidental pushes
chatton
commented
Feb 17, 2021
| value: "mongodb-kubernetes-operator" | ||
| - name: AGENT_IMAGE # The MongoDB Agent the operator will deploy to manage MongoDB deployments | ||
| value: quay.io/mongodb/mongodb-agent:10.19.0.6562-1 | ||
| value: quay.io/mongodb/mongodb-agent:10.27.0.6772-1 |
Contributor
Author
There was a problem hiding this comment.
this version of the agent allows us to provide the dummy configuration
bznein
approved these changes
Feb 18, 2021
Contributor
bznein
left a comment
bznein
left a comment
There was a problem hiding this comment.
Negative diff, short PR that makes a huge impact on the operator? LGTM!
| BUNDLE_IMG ?= controller-bundle:$(VERSION) | ||
|
|
||
| # Image URL to use all building/pushing image targets | ||
| IMG ?= quay.io/mongodb/mongodb-kubernetes-operator:0.5.0 # replace with localhost:5000/mongodb-kubernetes-operator locally |
| value: "mongodb-kubernetes-operator" | ||
| - name: AGENT_IMAGE # The MongoDB Agent the operator will deploy to manage MongoDB deployments | ||
| value: quay.io/mongodb/mongodb-agent:10.19.0.6562-1 | ||
| value: quay.io/mongodb/mongodb-agent:10.27.0.6772-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).This PR upgrades the agent version to a version which supports allowing versions of MongoDB which are not present in the version manifest.
closes #255