CLOUDP-83092: Add init container images to inventory file #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
commented
Apr 20, 2021
| GOLANG_TAG = "1.14" | ||
|
|
||
|
|
||
| def _shared_agent_params() -> DockerParameters: |
Contributor
Author
There was a problem hiding this comment.
forgot to remove these when I added the agent stages to inventory.yaml
2 tasks
rodrigovalin
approved these changes
Apr 21, 2021
Contributor
rodrigovalin
left a comment
rodrigovalin
left a comment
There was a problem hiding this comment.
LGTM!
I'm happy to see Sonar being used in multiple places now 🚀
chatton
deleted the
CLOUDP-83092_add_init_container_images_to_inventory_file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
This PR adds the readiness probe and version upgrade hook init containers to the inventory.yaml file.