CLOUDP-85550: mark github issues stale #434
Conversation
jamesbroadhead
requested review from
bznein,
chatton,
irajdeep and
rodrigovalin
bznein
left a comment
bznein
left a comment
There was a problem hiding this comment.
Looking good to me, just a couple of comments
| close-issue-message: 'This issue was closed because it became stale. If the issue is still affecting you, please re-open it, or file a fresh Issue with updated information.' | ||
|
|
||
| days-before-stale: 80 | ||
| days-before-close: 100 |
There was a problem hiding this comment.
Looking at the docs:
days-before-close | Idle number of days before closing an stale issue/PR.Defaults to 7.
-- | --
So we should have 20 in this case? otherwise it will take a total of 180 days to close an issue?
There was a problem hiding this comment.
Looking at the example:
name: 'Close stale issues and PRs'
on:
schedule:
- cron: '30 1 * * *'
jobs:
stale:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v3
with:
stale-issue-message: 'This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.'
days-before-stale: 30
days-before-close: 5
Look like we need to change 100 to 20
There was a problem hiding this comment.
good point - thank you!
I've tweaked the numbers to make the stale-tagging sooner, and give longer for updates
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
| stale-issue-message: 'This issue is being marked stale because it has been open for 80 days with no activity. Please comment if this issue is still affecting you. If there is no change, this issue will be closed in 20 days.' | ||
| stale-pr-message: 'This PR is being marked stale because it has been open for 80 days with no activity. Please upadte the PR or ask for a fresh review' | ||
| close-issue-message: 'This issue was closed because it became stale. If the issue is still affecting you, please re-open it, or file a fresh Issue with updated information.' |
There was a problem hiding this comment.
From a non-native speaker, this sounds like "as soon as it became stale, it was closed"
I would probably rephrase it as "because it has been stale for 20 days"
There was a problem hiding this comment.
+1 for more detailed message
There was a problem hiding this comment.
Ok - but bear in mind that these issues will also have stale-issue-message on them by that point
Co-authored-by: Nikolas De Giorgis <nikolas.de-giorgis@10gen.com>
jamesbroadhead
changed the title
Reviewers: please review for correctness - but also for the set of config options I've selected here; let me know if you think they'll lead to a bad experience
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).