CLOUDP-83092: Add context images for agents. #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com:mongodb/mongodb-kubernetes-operator into CLOUDP-83092_add_release_task_for_init_containers
chatton
changed the base branch from
master
to
CLOUDP-83092_add_release_task_for_init_containers
Base automatically changed from
CLOUDP-83092_add_release_task_for_init_containers
to
master
April 22, 2021 09:21
rodrigovalin
approved these changes
Apr 23, 2021
Contributor
rodrigovalin
left a comment
rodrigovalin
left a comment
There was a problem hiding this comment.
LGTM with one comment.
- no blocker: I think the agent's builder Docker file can be made a little less verbose by using ADD, it can be done easily
| - tools_version | ||
| - tools_distro | ||
| - agent_distro | ||
| - noop |
Contributor
There was a problem hiding this comment.
I think you fixed this already :)
Contributor
Author
There was a problem hiding this comment.
we haven't yet released 0.10.0, but let's do that now, no harm!
| @@ -0,0 +1,18 @@ | |||
| FROM curlimages/curl:7.76.1 as builder | |||
Contributor
There was a problem hiding this comment.
I think this one can be replaced by a scratch image like
FROM scratch
ADD https://mciuploads.s3.amazonaws.com/mms-automation/mongodb-mms-build-agent/builds/automation-agent/prod/mongodb-mms-automation-agent-${agent_version}.${agent_distro}.tar.gz /data/mongodb-agent.tgz
ADD https://downloads.mongodb.org/tools/db/mongodb-database-tools-${tools_distro}-${tools_version}.tgz /data/mongodb-tools.tgz
ADD agent/LICENSE /data/licensesInstead of the multi-stage build with curl.
Comment on lines
18
to
19
| COPY --from=base /data/mongodb-agent.tar.gz agent | ||
| COPY --from=base data/mongodb-tools.tgz . |
Contributor
There was a problem hiding this comment.
Sources and destinations are really different here. Why is that? It is kind of confusing.
| && chmod ugo+rw /var/log/mongodb-mms-automation/readiness.log | ||
|
|
||
|
|
||
| COPY --from=base /data/mongodb-agent.tar.gz agent |
Contributor
There was a problem hiding this comment.
Can we use absolute directories for the destination? Or it will depend on current WORKDIR
Contributor
Author
|
@rodrigovalin updated based on your feedback! Everything is using absolute paths now. |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
This PR refactors the agent Dockerfiles to now use a context builder.