CLOUDP-85272: remove persistence method from interface #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
approved these changes
Apr 26, 2021
Contributor
chatton
left a comment
chatton
left a comment
There was a problem hiding this comment.
LGTM once the tests pass!
bznein
deleted the
CLOUDP-85752_remove_persistent_field_from_AppDB_Community
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was added to support the AppDB project.
However, there is no need (and it's actually harmful) to allow customers to specify persistence=false in the AppDB, and we never supported that here in Community.
This PR completely removes the method from the interface and an analogous PR on Enterprise will remove it from the AppDB
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).