Add GitHub Action to Release All Images #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r_release_to_pipeline
chatton
changed the base branch from
add_github_action_to_create_release_pr
to
master
chatton
changed the base branch from
master
to
add_github_action_to_create_release_pr
chatton
requested review from
bznein,
ciprian-tibulca,
irajdeep,
priyolahiri and
rodrigovalin
as code owners
| raise ValueError("usage: determine_required_releases.py [image-name]") | ||
| image_name_map = _load_image_name_to_version_map() | ||
|
|
||
| if sys.argv[1] not in image_name_map: |
There was a problem hiding this comment.
can we define a variable image_name = sys.argv[1] and use it in all 6 places?
| args.image_name | ||
| ) | ||
| ) | ||
| return 0 |
There was a problem hiding this comment.
do we want to exit here with code 0 or an error code?
Contributor
Author
There was a problem hiding this comment.
right good catch, the reason for a 0 here rather than error, is that we run this task for every image we are going to release. This will update the release as a support version (for agent only currently), but we need this to be a no-op rather than failure for the other images.
This task will currently only fail if there is an error when interacting with the release database in Atlas.
ciprian-tibulca
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub Action which builds and pushes all of our images to Quay. The release process is as follows.
Create Release PRaction (master branch release.json should contain the desired versions, any that do not exist, will be built and released. no-op for already released images.)This PR also includes a bump for the operator to version 0.6.1, so when the release task is called we can release this new operator version.
The evergreen release tasks have been removed.