CLOUDP-92631: mongodb log to stdout #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bznein
requested review from
chatton,
ciprian-tibulca,
irajdeep,
priyolahiri and
rodrigovalin
as code owners
bznein
commented
Jun 21, 2021
Comment on lines
-217
to
-221
| process.SetSystemLog(SystemLog{ | ||
| Destination: "file", | ||
| Path: path.Join(DefaultAgentLogPath, "/mongodb.log"), | ||
| LogAppend: true, | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
By removing this mongodb now by default sends its output to stdout: https://docs.mongodb.com/manual/reference/configuration-options/#mongodb-setting-systemLog.destination
|
|
||
| s := secret.Builder(). | ||
| SetName(secretNsName.Name). | ||
| SetNamespace(secretNsName.Namespace). |
Contributor
Author
There was a problem hiding this comment.
changes in this file are unrelated and come from pre-commit hook errors
chatton
approved these changes
Jun 21, 2021
Contributor
chatton
left a comment
chatton
left a comment
There was a problem hiding this comment.
LGTM thanks for the quick fix. Can we update the release notes before merging though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #570
by not defaulting to saving
mongodblogs to file. Users can still obtain the old behaviour throughspec.additionalMongodConfigAll Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).