This repository was archived by the owner on Dec 12, 2025. It is now read-only.
Accepts metrics.prometheus endpoint.
#888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigovalin
requested review from
chatton,
ciprian-tibulca,
irajdeep,
mircea-cosbuc and
priyolahiri
as code owners
rodrigovalin
force-pushed
the
CLOUDP-112098_configure_prometheus
branch
2 times, most recently
from
40ecfc8 to
ca62366
Compare
rodrigovalin
force-pushed
the
CLOUDP-112098_configure_prometheus
branch
from
ca62366 to
3c7ff35
Compare
irajdeep
reviewed
Feb 17, 2022
api/v1/mongodbcommunity_types.go
Outdated
| AuthenticationRestrictions []AuthenticationRestriction `json:"authenticationRestrictions,omitempty"` | ||
| } | ||
|
|
||
| type Metrics struct { |
Contributor
There was a problem hiding this comment.
Q: Any reason to wrap this in Metrics struct instead of using Prometheus struct directly?
Contributor
Author
There was a problem hiding this comment.
No reason in particular, maybe preparing for other options in the future, to go besides Prometheus; but I think that posibility is unlikely.
I don't have a strong opinion. Maybe it is unecessary at this point. I will remove
irajdeep
reviewed
Feb 17, 2022
| Username: username, | ||
| Scheme: "http", | ||
| Mode: "opsManager", | ||
| ListenAddress: "0.0.0.0:9216", |
Contributor
There was a problem hiding this comment.
Should we hardcode the port here? can it be changed on some usecase?
Contributor
Author
There was a problem hiding this comment.
It can be changed from CRD via prometheus.port, this is just the default.
irajdeep
approved these changes
Feb 17, 2022
Contributor
irajdeep
left a comment
irajdeep
left a comment
There was a problem hiding this comment.
LGTM -- added some minor comments.
rodrigovalin
force-pushed
the
CLOUDP-112098_configure_prometheus
branch
from
068bc5e to
295f9b9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using latest agent, we can pass a
spec.metrics.prometheusconfiguration that will result in an automation_config change that enables a/metricsendpoint that can be used with Prometheus.Dependencies
We need to publish a new agent version before these changes are even recognized by the agents.