Skip to content

Conversation

@nammn
Copy link
Collaborator

@nammn nammn commented Apr 22, 2025

Summary

  • done by doing the following on the new branch:

    • git diff meko/master..meko/mck-merge > /tmp/changes.patch
    • rm mongodb-community-operator
    • git apply /tmp/changes.patch
  • with this the missing change-set between meko/mck-merge and mck/mck-merge should align

Proof of Work

  • green ci

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@nammn nammn requested review from Julien-Ben and m1kola April 22, 2025 12:08
Co-Authored-By: Yavor Georgiev <yavor.georgiev@mongodb.com>
Co-Authored-By: Nam Nguyen <nam.nguyen.de@gmail.com>
Co-Authored-By: Mikalai Radchuk <509198+m1kola@users.noreply.github.com>
Copy link
Collaborator

@Julien-Ben Julien-Ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it and take a look a the failing tests as a follow up

@nammn nammn merged commit 26f0c1c into master Apr 22, 2025
1 check was pending
@m1kola m1kola mentioned this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants