Skip to content

Apply missing changes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Apply missing changes #3

wants to merge 1 commit into from

Conversation

@m1kola
Copy link
Contributor

@m1kola m1kola commented Apr 17, 2025 •
edited
Loading

This is the diff between mck-merge branch in the old repo and mck-merge in the new repo.

@m1kola m1kola requested review from Julien-Ben and nammn April 17, 2025 16:27
m1kola
m1kola commented Apr 17, 2025
View reviewed changes
@m1kola m1kola mentioned this pull request Apr 17, 2025
Merged
@m1kola m1kola marked this pull request as ready for review April 17, 2025 18:04
@m1kola
Copy link
Contributor Author

m1kola commented Apr 22, 2025

Moving back to draft because we are renaming branches and might need to change the target branch.

@m1kola m1kola marked this pull request as draft April 22, 2025 07:58
@m1kola m1kola changed the base branch from mck-merge to main April 22, 2025 08:05
@m1kola m1kola changed the base branch from main to mck-merge April 22, 2025 08:08
@m1kola m1kola changed the base branch from mck-merge to main April 22, 2025 09:29
@m1kola m1kola marked this pull request as ready for review April 22, 2025 09:31
@m1kola
Copy link
Contributor Author

m1kola commented Apr 22, 2025

Re-targeted to main

@m1kola
Copy link
Contributor Author

m1kola commented Apr 22, 2025

Something is up with generated code. Investigating

github.com/mongodb/mongodb-kubernetes-operator/api/v1:-: CRD for MongoDBCommunity.mongodbcommunity.mongodb.com has no storage version
Error: not all generators ran successfully
run `controller-gen crd rbac:roleName=manager-role paths=./... output:crd:artifacts:config=config/crd/bases -w` to see all available markers, or `controller-gen crd rbac:roleName=manager-role paths=./... output:crd:artifacts:config=config/crd/bases -h` for usage
make: *** [manifests] Error 1

@m1kola m1kola marked this pull request as draft April 22, 2025 10:21
@m1kola
Copy link
Contributor Author

m1kola commented Apr 22, 2025

No longer needed because #17 contains everything.

@m1kola m1kola closed this Apr 22, 2025
@m1kola m1kola deleted the mck-merge-fixup branch April 22, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nammn nammn Awaiting requested review from nammn

@Julien-Ben Julien-Ben Awaiting requested review from Julien-Ben

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@m1kola