Fix couple multicluster flaky tests #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.6.0 Release NotesNew Features
Bug Fixes
|
MaciejKaras
commented
Oct 29, 2025
| else: | ||
| raise e | ||
|
|
||
| run_periodically( |
Collaborator
Author
There was a problem hiding this comment.
This is racy, because stateful set is immediately recreated by operator
MaciejKaras
commented
Oct 29, 2025
| sleep 1 | ||
|
|
||
| local service_account_name="operator-tests-multi-cluster-service-account" | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
duplicated code that is already present jus below. Creating Multi Cluster configuration secret shows twice in the logs as well
MaciejKaras
commented
Oct 29, 2025
| fi | ||
|
|
||
| member_cluster_token="$(kubectl --context "${member_cluster}" get secret "${secret_name}" -o jsonpath='{ .data.token}' -n "${NAMESPACE}" | base64 -d)" | ||
| # Retry up to 10 times if .data.token is not yet populated |
Collaborator
Author
There was a problem hiding this comment.
secrets .data.token is populated asynchronously after the secret is created. We need to wait for it become available, otherwise the member_cluster_token will be empty
MaciejKaras
commented
Oct 29, 2025
|
|
||
| - name: e2e_multi_cluster_validation | ||
| tags: [ "patch-run" ] | ||
| exec_timeout_secs: 1000 |
Collaborator
Author
There was a problem hiding this comment.
this is not needed and prevents us from collecting test data
MaciejKaras
added
the
skip-changelog
MaciejKaras
requested review from
Julien-Ben,
lsierant,
nammn and
viveksinghggits
and removed request for
nammn and
viveksinghggits
Julien-Ben
approved these changes
Oct 29, 2025
Collaborator
Julien-Ben
left a comment
Julien-Ben
left a comment
There was a problem hiding this comment.
One of the greenest CI I've seen in the last days 😍
lsierant
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Couple small fixes that together with @lsierant we have found during recent investigation. Details are provided in the PR comments.
Proof of Work
Passing CI.
Checklist
skip-changeloglabel if not needed