Skip to content

Conversation

@viveksinghggits
Copy link
Contributor

@viveksinghggits viveksinghggits commented Nov 17, 2025

Summary

In our release guide we ask to just create a draft release using the release tag and because of that the kubectl plugin promotion workflow was broken in the sense that the script was not able to upload the assets to the draft release. It was able to upload the assets just to the published releases.

This PR makes sure that the promotion script is able to upload the assets to even a draft release.

Proof of Work

Screen.Recording.2025-11-17.at.15.28.17.mov

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you added changelog file?

@viveksinghggits viveksinghggits requested a review from a team as a code owner November 17, 2025 14:39
@viveksinghggits viveksinghggits added the skip-changelog Use this label in Pull Request to not require new changelog entry file label Nov 17, 2025
@github-actions
Copy link

⚠️ (this preview might not be accurate if the PR is not rebased on current master branch)

MCK 1.6.1 Release Notes

1. Fail if gh release is not found
@viveksinghggits
Copy link
Contributor Author

viveksinghggits commented Nov 19, 2025

Hi @mircea-cosbuc,
Can you please look into/approve this PR?

Copy link
Member

@mircea-cosbuc mircea-cosbuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viveksinghggits viveksinghggits merged commit 122eaa5 into master Nov 21, 2025
34 of 37 checks passed
@viveksinghggits viveksinghggits deleted the fix-plugin-release-to-draft branch November 21, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use this label in Pull Request to not require new changelog entry file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants