Skip to content

Fix "draft release note found" while promoting kubectl plugin #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2025
Merged

Fix "draft release note found" while promoting kubectl plugin #601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9478884
Fix "draft release note found" while promoting kubectl plugin
viveksinghggits Nov 17, 2025
318ea32
Address review comment
viveksinghggits Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions scripts/release/kubectl_mongodb/promote_kubectl_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,18 +285,27 @@ def upload_assets_to_github_release(asset_paths: list[str], release_version: str
sys.exit(1)

try:
release = repo.get_release(release_version)
gh_release = None
# list all the releases (including draft ones), and get the one corresponding to the passed release_version
for r in repo.get_releases():
if r.tag_name == release_version:
gh_release = r
break

if gh_release is None:
logger.error(
f"Could not find release (published or draft) with tag '{release_version}'. Please ensure the release exists."
)
sys.exit(2)
except GithubException as e:
logger.debug(
f"ERROR: Could not find release with tag '{release_version}'. Please ensure release exists already. Error: {e}"
)
logger.debug(f"Failed to retrieve releases from the repository {GITHUB_REPO}. Error: {e}")
sys.exit(2)

for asset_path in asset_paths:
asset_name = os.path.basename(asset_path)
logger.info(f"Uploading artifact '{asset_name}' to github release as asset")
try:
release.upload_asset(path=asset_path, name=asset_name, content_type="application/gzip")
gh_release.upload_asset(path=asset_path, name=asset_name, content_type="application/gzip")
except GithubException as e:
logger.debug(f"ERROR: Failed to upload asset {asset_name}. Error: {e}")
sys.exit(2)
Expand Down