Skip to content

Conversation

@dariakp
Copy link
Contributor

@dariakp dariakp commented Jan 21, 2022

Description

NODE-3719

What is changing?

Separating prose tests from the general change stream test file.

Also noticed a crud prose test in the wrong place, so moved that, too.

Also noticed duplicate/strangely implemented versioned api test and deleted it (it's covered in the mongo_client unit tests).

Is there new documentation needed for these changes?

N/A

What is the motivation for this change?

Spec compliance review

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp marked this pull request as ready for review January 21, 2022 21:26
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hold on merging, I missed part of reviewing this.

@nbbeeken nbbeeken merged commit dd81438 into main Jan 25, 2022
@nbbeeken nbbeeken deleted the NODE-3719/identify-change-stream-prose-tests branch January 25, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants