Skip to content

test: skip TLS tests when node >v24 #4737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 16, 2025
Merged

test: skip TLS tests when node >v24 #4737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ba8330d
skip client side encryption tests for node v25
PavelSafronov Oct 16, 2025
c452aa6
Merge branch 'mongodb:main' into NODE-7250
PavelSafronov Oct 16, 2025
5a000c1
Merge branch 'main' into NODE-7250
PavelSafronov Oct 16, 2025
9414538
fix lint issue
PavelSafronov Oct 16, 2025
815c754
Merge branch 'NODE-7250' of https://github.com/PavelSafronov/node-mon…
PavelSafronov Oct 16, 2025
ba3d720
pr feedback: narrower scope on what tests we skip
PavelSafronov Oct 16, 2025
3dcf05b
Merge branch 'main' into NODE-7250
PavelSafronov Oct 16, 2025
6f3c05a
lint fix
PavelSafronov Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/integration/client-side-encryption/client_side_encryption.prose.10.kms_tls.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
import { expect } from 'chai';
import { satisfies } from 'semver';

import { getCSFLEKMSProviders } from '../../csfle-kms-providers';
import { ClientEncryption, type MongoClient } from '../../mongodb';

const metadata: MongoDBMetadataUI = {
requires: {
clientSideEncryption: true
clientSideEncryption: true,
predicate: () =>
satisfies(process.version, '<25.0.0') ? true : 'TODO(NODE-7252): fix these tests in v25'
}
};

Expand Down
42 changes: 26 additions & 16 deletions test/integration/client-side-encryption/client_side_encryption.prose.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { BSON, EJSON } from 'bson';
import { expect } from 'chai';
import * as fs from 'fs/promises';
import * as path from 'path';
import { satisfies } from 'semver';

import { ClientEncryption } from '../../../src/client-side-encryption/client_encryption';
import { getCSFLEKMSProviders } from '../../csfle-kms-providers';
Expand Down Expand Up @@ -46,6 +47,15 @@ const metadata: MongoDBMetadataUI = {
}
};

const kmsTlsMetadata: MongoDBMetadataUI = {
requires: {
clientSideEncryption: true,
topology: '!load-balanced',
predicate: () =>
satisfies(process.version, '<25.0.0') ? true : 'TODO(NODE-7252): fix these tests in v25'
}
};

const eeMetadata: MongoDBMetadataUI = {
requires: {
clientSideEncryption: true,
Expand Down Expand Up @@ -1369,7 +1379,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
* - Create client encryption expired
* - Create client encryption invalid hostname
*/
context('KMS TLS Options Tests', metadata, function () {
context('KMS TLS Options Tests', kmsTlsMetadata, function () {
let clientNoTls;
let clientWithTls;
let clientWithTlsExpired;
Expand Down Expand Up @@ -1506,7 +1516,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
});

// Case 1.
context('Case 1: AWS', metadata, function () {
context('Case 1: AWS', kmsTlsMetadata, function () {
const masterKey = {
region: 'us-east-1',
key: 'arn:aws:kms:us-east-1:579766882180:key/89fcc2c4-08b0-4bd9-9f25-e30687b580d0',
Expand All @@ -1515,7 +1525,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
const masterKeyExpired = { ...masterKey, endpoint: '127.0.0.1:9000' };
const masterKeyInvalidHostname = { ...masterKey, endpoint: '127.0.0.1:9001' };

it('should fail with no TLS', metadata, async function () {
it('should fail with no TLS', async function () {
// NODE-6861: flakiness is caused by mock KMS servers
this.retries(2);

Expand All @@ -1528,7 +1538,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
}
});

it('should succeed with valid TLS options', metadata, async function () {
it('should succeed with valid TLS options', async function () {
try {
await clientEncryptionWithTls.createDataKey('aws', { masterKey });
expect.fail('it must fail to parse response');
Expand All @@ -1551,7 +1561,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
}
});

it('should fail with an invalid hostname', metadata, async function () {
it('should fail with an invalid hostname', async function () {
try {
await clientEncryptionWithInvalidHostname.createDataKey('aws', {
masterKey: masterKeyInvalidHostname
Expand All @@ -1565,13 +1575,13 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
});

// Case 2.
context('Case 2: Azure', metadata, function () {
context('Case 2: Azure', kmsTlsMetadata, function () {
const masterKey = {
keyVaultEndpoint: 'doesnotexist.invalid',
keyName: 'foo'
};

it('should fail with no TLS', metadata, async function () {
it('should fail with no TLS', async function () {
// NODE-6861: flakiness is caused by mock KMS servers
this.retries(2);

Expand All @@ -1584,7 +1594,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
}
});

it('should succeed with valid TLS options', metadata, async function () {
it('should succeed with valid TLS options', async function () {
try {
await clientEncryptionWithTls.createDataKey('azure', { masterKey });
expect.fail('it must fail with HTTP 404');
Expand All @@ -1605,7 +1615,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
}
});

it('should fail with an invalid hostname', metadata, async function () {
it('should fail with an invalid hostname', async function () {
try {
await clientEncryptionWithInvalidHostname.createDataKey('azure', { masterKey });
expect.fail('it must fail with invalid hostnames');
Expand All @@ -1617,15 +1627,15 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
});

// Case 3.
context('Case 3: GCP', metadata, function () {
context('Case 3: GCP', kmsTlsMetadata, function () {
const masterKey = {
projectId: 'foo',
location: 'bar',
keyRing: 'baz',
keyName: 'foo'
};

it('should fail with no TLS', metadata, async function () {
it('should fail with no TLS', async function () {
// NODE-6861: flakiness is caused by mock KMS servers
this.retries(2);

Expand All @@ -1638,7 +1648,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
}
});

it('should succeed with valid TLS options', metadata, async function () {
it('should succeed with valid TLS options', async function () {
try {
await clientEncryptionWithTls.createDataKey('gcp', { masterKey });
expect.fail('it must fail with HTTP 404');
Expand All @@ -1659,7 +1669,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
}
});

it('should fail with an invalid hostname', metadata, async function () {
it('should fail with an invalid hostname', async function () {
try {
await clientEncryptionWithInvalidHostname.createDataKey('gcp', { masterKey });
expect.fail('it must fail with invalid hostnames');
Expand All @@ -1671,7 +1681,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
});

// Case 4.
context('Case 4: KMIP', metadata, function () {
context('Case 4: KMIP', kmsTlsMetadata, function () {
const masterKey = {};

it('should fail with no TLS', metadata, async function () {
Expand Down Expand Up @@ -1699,7 +1709,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
}
});

it('should fail with an invalid hostname', metadata, async function () {
it('should fail with an invalid hostname', async function () {
try {
await clientEncryptionWithInvalidHostname.createDataKey('kmip', { masterKey });
expect.fail('it must fail with invalid hostnames');
Expand All @@ -1717,7 +1727,7 @@ describe('Client Side Encryption Prose Tests', metadata, function () {
function () {}
).skipReason = 'TODO(NODE-4840): Node does not support any OCSP options';

context('Case 6: named KMS providers apply TLS options', function () {
context('Case 6: named KMS providers apply TLS options', kmsTlsMetadata, function () {
afterEach(() => keyvaultClient?.close());
beforeEach(async function () {
const shouldSkip = this.configuration.filters.ClientSideEncryptionFilter.filter({
Expand Down