Skip to content

test(NODE-5206): fix flaky sdam prose test #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

test(NODE-5206): fix flaky sdam prose test #4752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions ...integration/server-discovery-and-monitoring/server_discovery_and_monitoring.prose.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,15 @@ describe('Server Discovery and Monitoring Prose Tests', function () {
*/

let client: MongoClient;
let utilClient: MongoClient;
const events: string[] = [];
beforeEach(async function () {
client = this.configuration.newClient({
directConnection: true,
appName: 'SDAMPoolManagementTest',
heartbeatFrequencyMS: 500
heartbeatFrequencyMS: 100
});
utilClient = this.configuration.newClient({ directConnection: true });

for (const event of [
CONNECTION_POOL_READY,
Expand Down Expand Up @@ -144,6 +146,7 @@ describe('Server Discovery and Monitoring Prose Tests', function () {

afterEach(async function () {
await client.close();
await utilClient.close();
});

it('ensure monitors properly create and unpause connection pools when they discover servers', {
Expand All @@ -156,7 +159,7 @@ describe('Server Discovery and Monitoring Prose Tests', function () {
expect(events).to.be.empty;

const heartBeatFailedEvent = once(client, SERVER_HEARTBEAT_FAILED);
await client.db('admin').command({
await utilClient.db('admin').command({
configureFailPoint: 'failCommand',
mode: { times: 2 },
data: {
Expand All @@ -165,17 +168,22 @@ describe('Server Discovery and Monitoring Prose Tests', function () {
appName: 'SDAMPoolManagementTest'
}
});

await heartBeatFailedEvent;
expect(events.shift()).to.equal(SERVER_HEARTBEAT_FAILED);
expect(events.shift()).to.equal(CONNECTION_POOL_CLEARED);

expect(events).to.be.empty;

await once(client, SERVER_HEARTBEAT_SUCCEEDED);
expect(events.shift()).to.equal(SERVER_HEARTBEAT_SUCCEEDED);
expect(events.shift()).to.equal(CONNECTION_POOL_READY);

expect(events).to.be.empty;
// In rare cases when using the stable API, an extra server heartbeat failed event may sneak in.
// The test just needs to assert that at some point we have another server heartbeat suceeded
// event followed by a connection pool ready event.
const filteredEvents = events.filter(event => event !== SERVER_HEARTBEAT_FAILED);
expect(filteredEvents.shift()).to.equal(SERVER_HEARTBEAT_SUCCEEDED);
expect(filteredEvents.shift()).to.equal(CONNECTION_POOL_READY);

expect(filteredEvents).to.be.empty;
}
});
});
Expand Down