Skip to content

fix(NODE-7247): clarify #rewrapManyDataKey() parameter types #4760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2025
+8 −2
Merged

fix(NODE-7247): clarify #rewrapManyDataKey() parameter types #4760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b88d2a4
feat(NODE-7247): clarify #rewrapManyDataKey() parameter types
tadjik1 Oct 28, 2025
2cea990
address PR feedback
tadjik1 Oct 29, 2025
d3aaf90
rollback unintentional evegreen-tools update
tadjik1 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
"check:eslint": "npm run build:dts && ESLINT_USE_FLAT_CONFIG=false eslint -v && ESLINT_USE_FLAT_CONFIG=false eslint --max-warnings=0 --ext '.js,.ts' src test",
"check:tsd": "tsd --version && tsd",
"check:dependencies": "mocha test/action/dependency.test.ts",
"check:dts": "node ./node_modules/typescript/bin/tsc --target es2015 --module node16 --noEmit mongodb.d.ts && tsd",
"check:dts": "node ./node_modules/typescript/bin/tsc --target es2023 --module commonjs --noEmit mongodb.d.ts && tsd",
"check:search-indexes": "nyc mocha --config test/mocha_mongodb.js test/manual/search-index-management.prose.test.ts",
"check:test": "mocha --config test/mocha_mongodb.js test/integration",
"check:unit": "nyc mocha test/unit",
Expand Down
2 changes: 1 addition & 1 deletion src/client-side-encryption/client_encryption.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ export class ClientEncryption {
*/
async rewrapManyDataKey(
filter: Filter<DataKey>,
options: ClientEncryptionRewrapManyDataKeyProviderOptions
options?: ClientEncryptionRewrapManyDataKeyProviderOptions
): Promise<{ bulkWriteResult?: BulkWriteResult }> {
let keyEncryptionKeyBson = undefined;
if (options) {
Expand Down
6 changes: 6 additions & 0 deletions test/types/client-side-encryption.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,3 +157,9 @@ expectAssignable<RequiredCreateEncryptedCollectionSettings>({
}
});
}

declare const clientEncryption: ClientEncryption;
{
await clientEncryption.rewrapManyDataKey({});
await clientEncryption.rewrapManyDataKey({}, { provider: 'aws' });
}