feat(NODE-7121): prevent connection churn on backpressure errors when establishing connections #4800
Conversation
baileympearson
force-pushed
the
NODE-7121
branch
2 times, most recently
from
f4f55f6 to
e14a3ef
Compare
baileympearson
force-pushed
the
NODE-7121
branch
3 times, most recently
from
ad9299d to
151b986
Compare
baileympearson
force-pushed
the
NODE-7121
branch
from
541a8e0 to
70c1333
Compare
| const res = server.command( | ||
| new RunCommandOperation(ns('admin.$cmd'), { ping: 1 }, {}), | ||
| TimeoutContext.create({ | ||
| serverSelectionTimeoutMS: 30_000, | ||
| waitQueueTimeoutMS: 10_000 | ||
| }) |
There was a problem hiding this comment.
Typescript wasn't properly inferring the types after command.bind() is called for some reason. After adjusting it to call command directly, I got a compiler error and had to provide a timeout context.
| ...HEARTBEAT_EVENTS | ||
| ]; | ||
|
|
||
| function makeConnectionsError(appError: ApplicationError): sinon.SinonStub[] { |
There was a problem hiding this comment.
Sorry for the large diff here, reviewers. Our test runner's old mocks were too permissive and allowed tests to pass that should have failed. I've adjusted this mocking logic:
- if we need to stub before handshake errors, I create stubs that provide the bare minimum needed for the actual handshake to fail. In practice, this means stubbing
net.createConnection(). - otherwise, I use rely on the old stub logic.
I've also adjusted the code to use switch statements instead of if-statements when switching on discriminated union fields, because TS errors if we haven't exhausted all switch statements.
baileympearson
force-pushed
the
NODE-7121
branch
from
70c1333 to
d3ec74a
Compare
baileympearson
changed the title
| const isNetworkTimeoutBeforeHandshakeError = | ||
| error instanceof MongoNetworkError && error.beforeHandshake; | ||
| const isAuthHandshakeError = error.hasErrorLabel(MongoErrorLabel.HandshakeError); | ||
| const isAuthOrEstablishmentHandshakeError = error.hasErrorLabel(MongoErrorLabel.HandshakeError); |
There was a problem hiding this comment.
renaming this is a minor cleanup and clarification - this label is also applied to the MongoDB handshake, not just auth.
1 participant
Description
Summary of Changes
This PR adopts the backpressure changes from mongodb/specifications#1860 and mongodb/specifications#1855.
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript